fix: kubelet --root-dir can be used #111
Conversation
| @@ -6,6 +6,7 @@ metadata: | |||
| data: | |||
| config.json: | | |||
| { | |||
| "kubeletRootDir": "/var/lib/kubelet", | |||
There was a problem hiding this comment.
lets have this one as a cli flag i dont think users should be concerned about it. (--kubelet-root-dir)
thats a deployment decision.
There was a problem hiding this comment.
normally, i also dont think users should be concerned about it, its default value is /var/lib/kubelet,
if necessary, users can set kubeletRootDir=xxx
There was a problem hiding this comment.
cli and configmap are two different configurations. If necessary, It can be changed to cli mode.
There was a problem hiding this comment.
It can be changed to cli mode.
that is my preference.
deployment/k8s/base/daemonset.yaml
Outdated
| @@ -21,6 +21,8 @@ spec: | |||
| securityContext: | |||
| privileged: true | |||
| volumeMounts: | |||
| # 如果configmap.yaml中指定了kubeletRootDir，则需要调整为相同的路径 | |||
deployment/k8s/base/daemonset.yaml
Outdated
| @@ -21,6 +21,8 @@ spec: | |||
| securityContext: | |||
| privileged: true | |||
| volumeMounts: | |||
| # 如果configmap.yaml中指定了kubeletRootDir，则需要调整为相同的路径 | |||
| # 如：kubeletRootDir=/data/kubelet，则mountPath=/data/kubelet/device-plugins | |||
| - name: device-plugin | |||
There was a problem hiding this comment.
just a note.
if kubelet root dir is different the two mounts below need to be updated in deployment. (thiis yaml is just example)
you dont want to mount entire */kubelet dir since it may cause issues as kubelet maintains other mounts under this root dir.
There was a problem hiding this comment.
also remove this comment :)
Signed-off-by: niuli33 <niuli33@jd.com> delete comments
to resolve issue #96