-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CDI #77
Conversation
5c02bd9
to
dad2e4e
Compare
@abdallahyas We don't have any copyrights in the repo, should we copyright all files or drop the check? |
@almaslennikov we can not drop because it is the company policy, so we can copy the copy right message from any other project and add it to only the newly added files. The CI will only check newly added files, and would ignore the modified files |
013c3b7
to
41cecf6
Compare
@e0ne addressed your comments and rebased the PR, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for addressing my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @almaslennikov appologies for the delayed review !
i have deployed the changes, something is off with the cdi spec, expect further feedback :) |
I have deployed device plugin in cdi mode. the cdi specification generated is as follows:
the list of devices goes on up until A couple of comments on this one:
example of a cdi spec file as i envision it: a resource pool with 2 devices:
|
1e36e9a
to
2a25547
Compare
592fd18
to
ddfce68
Compare
e37dc5f
to
c19a164
Compare
https://github.com/container-orchestrated-devices/container-device-interface Add copyrights to all edited files Switch to kustomize for deployment artifacts Update Readme Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
c19a164
to
914cfde
Compare
https://github.com/container-orchestrated-devices/container-device-interface