Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: 1050049 Move poll_os logic to the internal thread #445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liranoz12
Copy link
Contributor

By default VMA checks the os fd once for 100 cq polls (VMA_RX_UDP_POLL_OS_RATIO)
in order to receive UDP packets with size > MTU.
This commit moves this logic to the internal thread which uses
epoll_wait() to indicates that non-offloaded data is available.
This commit removes VMA_RX_UDP_POLL_OS_RATIO parameter.

Signed-off-by: Liran Oz lirano@mellanox.com

@mellanox-github
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1592/ for details (Mellanox internal link).

@mellanox-github
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1597/ for details (Mellanox internal link).

@mellanox-github
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1598/ for details (Mellanox internal link).

@mellanox-github
Copy link

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1602/ for details (Mellanox internal link).

Similar to VMA_RX_SKIP_OS, but in select(), poll() or epoll_wait() this will
force the VMA to check the non offloaded fd even though an offloaded socket
has ready packets found while polling.
This will force the VMA to check the non offloaded fd even though an offloaded
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

@liranoz12 liranoz12 removed the vNext label Aug 28, 2017
liranoz12 pushed a commit to liranoz12/libvma that referenced this pull request Sep 4, 2017
This commit is not based on udp poll os commit (pr Mellanox#445).

Signed-off-by: Liran Oz <lirano@mellanox.com>
liranoz12 pushed a commit to liranoz12/libvma that referenced this pull request Sep 10, 2017
This commit is not based on udp poll os commit (pr Mellanox#445).

* f0adf45 issue: 1117626 Move epoll poll_os logic to the internal thread

Signed-off-by: Liran Oz <lirano@mellanox.com>
liranoz12 pushed a commit to liranoz12/libvma that referenced this pull request Sep 13, 2017
This commit is not based on udp poll os commit (pr Mellanox#445).
Fix review comments
Remove boolean var from io_mux_call::handle_os_countdown()

* 6a0b53a issue: 1117626 Move epoll poll_os logic to the internal thread
* b1de6f5 issue: 1117626 Move epoll poll_os logic to the internal thread
* f0adf45 issue: 1117626 Move epoll poll_os logic to the internal thread

Signed-off-by: Liran Oz <lirano@mellanox.com>
@swx-jenkins3
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1681/ for details (Mellanox internal link).

@liranoz12
Copy link
Contributor Author

bot:retest

@swx-jenkins3
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1683/ for details (Mellanox internal link).

@liranoz12 liranoz12 added vNext and removed 8.4.x labels Sep 24, 2017
@liranoz12
Copy link
Contributor Author

bot:retest

@swx-jenkins3
Copy link

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1702/ for details (Mellanox internal link).

@liranoz12 liranoz12 added 8.5.x and removed vNext labels Oct 3, 2017
@swx-jenkins2
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2030/ for details (Mellanox internal link).

@swx-jenkins2
Copy link

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2601/ for details (Mellanox internal link).

@swx-jenkins2
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2665/ for details (Mellanox internal link).

@liranoz12
Copy link
Contributor Author

bot:retest

@swx-jenkins2
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2704/ for details (Mellanox internal link).

@liranoz12
Copy link
Contributor Author

bot:retest

@swx-jenkins2
Copy link

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2716/ for details (Mellanox internal link).

@liranoz12 liranoz12 added 8.8.x and removed 8.7 labels Oct 22, 2018
By default VMA checks the os fd once for 100 cq polls (VMA_RX_UDP_POLL_OS_RATIO)
in order to receive UDP packets with size > MTU.
This commit moves this logic to the internal thread which uses
epoll_wait() to indicates that non-offloaded data is available.
This commit removes VMA_RX_UDP_POLL_OS_RATIO parameter.

Signed-off-by: Liran Oz <lirano@mellanox.com>
@swx-jenkins2
Copy link

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/2912/ for details (Mellanox internal link).

@igor-ivanov igor-ivanov removed the 8.8.x label Aug 15, 2019
@swx-jenkins2
Copy link

Can one of the admins verify this patch?

@igor-ivanov
Copy link
Collaborator

can be usefull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants