Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: 3382805 Fixing incorrect handling of src field of IPv4 routing #126

Merged
merged 5 commits into from
Aug 21, 2024
Merged

issue: 3382805 Fixing incorrect handling of src field of IPv4 routing #126

merged 5 commits into from
Aug 21, 2024

Commits on Aug 19, 2024

  1. issue: 3382805 Use routing result if_index to identify device 

    Instead of using src address of the routing resolution result to identify interface, especially in IPv4 multicast case,
use the if_index of the routing result.

Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
    @AlexanderGrissik
    AlexanderGrissik committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9b73adf View commit details
    Browse the repository at this point in the history

  2. issue: 3382805 Avoid attempt routing src in registering routing observer 

    In case of IPv4 bind to any ip avoid trying to register dst_entry as observer with routing src field
which should be used for outgoing address selection and not for routing rule decisions.

What was happening: If we found routing for any IP, we looked if that routing has src-ip field.
In case of IPv4, if routing entry has no src-ip (which is common), we forcefully set it to the first address of the device related to this routing entry.
And so, we go and look for another routing entry by giving now the src field of the routing we found.
That src field affects the routing rule selection. Appart the fact this is not hte goal of the src routing field,
in most cases it ends up with the same device we dicovered at first place.

Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
    @AlexanderGrissik
    AlexanderGrissik committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b1f24d0 View commit details
    Browse the repository at this point in the history

  3. issue: 3382805 Avoid forcing src address to route entries 

    Route entry src field should be used for src addr selection algorithm.
Forcing src addr based on interface IPs may lead to wrong src addr selection.

Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
    @AlexanderGrissik
    AlexanderGrissik committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    51ade9b View commit details
    Browse the repository at this point in the history

  4. issue: 3382805 Remove unused routing entry per device 

    Registering a route entry per device is not used. The entry does not track device up/down events.

Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
    @AlexanderGrissik
    AlexanderGrissik committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4b7e1fc View commit details
    Browse the repository at this point in the history

  5. issue: 3382805 Remove special routing cfg src addr field 

    The m_src_addr field can be used now. No need for special one.

Signed-off-by: Alexander Grissik <agrissik@nvidia.com>
    @AlexanderGrissik
    AlexanderGrissik committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5b77477 View commit details
    Browse the repository at this point in the history