Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: 3949975 Fix -Wtemplate-id-cdtor in xlio_list #157

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

pasis
Copy link
Member

@pasis pasis commented Jun 4, 2024

Description

Starting from gcc-14, it generates template-id-cdtor error on a constructor with a template id.

What

Fix gcc-14 build.

Why ?

Fix gcc-14 build.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

@galnoam
Copy link
Collaborator

galnoam commented Jun 5, 2024

@pasis , can you fix style and cov?

This fixes gcc-14 build.

Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
@pasis pasis changed the title issue: Fix -Wtemplate-id-cdtor in xlio_list issue: 3949975 Fix -Wtemplate-id-cdtor in xlio_list Jun 13, 2024
@pasis
Copy link
Member Author

pasis commented Jul 12, 2024

bot:retest

@AlexanderGrissik AlexanderGrissik merged commit 448a650 into Mellanox:vNext Jul 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants