issue: HPCINFRA-1798 Print version information in the style CI job #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viacheslav Login <vlogin@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Test cov-2023.12 module and NFS-located binaries against RMAX codebase Signed-off-by: Viacheslav Login <vlogin@nvidia.com>
This field is used to avoid partial write of logical data blocks like PDUs. However, XLIO supports send buffer "overcommit" now and allows to push more data to the queue than the send buffer allows. Use this property of the send buffer to allow a single NVME PDU to exceed the limitation. This will save extra field per socket and simplify logic. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Printing a buffer is an unlikely branch, so no need to inline it. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
While a socket is locked, it's state cannot be changed and the only scenario to change the state is to call polling or TCP timers. In the TX path we don't call timers and polling is called when the send buffer is full. Therefore, it's enough to check the connection state under the lock once for non-blocking sockets. For blocking sockets the check can be moved after the polling, because the connection state cannot be changed before. Check for g_b_exit is relevant only for blocking operations, so check it just before polling. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
list_node is always inlined to a class and its offset is known. Therefore, we can find the object pointer with a single arithmetic operation and save 8 bytes per list_node. Remove the list iterator. It's mostly unused and requires special treatment of the head and tail. Replace it with next() and prev(). Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve style issues in CI.
What
Resolve style issues in CI.
Why ?
Resolve style issues in CI.
Change type
What kind of change does this PR introduce?
Check list