issue: 3925885 Adjusting XLIO default allocation logic #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
src/core/dev/net_device_val.cpp
Outdated
| @@ -70,8 +70,12 @@ | |||
| #define nd_logfunc __log_info_func | |||
| #define nd_logfuncall __log_info_funcall | |||
|
|
|||
| //This constructor is called to initialize class members of type ring_alloc_logic_attr that are not | |||
There was a problem hiding this comment.
The first 3 lines are obvious and not needed.
Its enough to say that the value given in this constructor is later always overridden.
BasharRadya
force-pushed
the
change_allocation_logic
branch
2 times, most recently
from
f81bb1a
to
99cf0f3
Compare
|
@BasharRadya , please fix conflicts. |
BasharRadya
force-pushed
the
change_allocation_logic
branch
from
99cf0f3
to
f0b2d5b
Compare
|
Should we disable progress engine by default as well? @AlexanderGrissik, WDYT? |
BasharRadya
force-pushed
the
change_allocation_logic
branch
2 times, most recently
from
3480fb3
to
e14bc55
Compare
|
bot:retest |
|
@dpressle, can you check why Bashars PRs do not trigger CI? |
|
bot:retest |
1 similar comment
|
bot:retest |
BasharRadya
force-pushed
the
change_allocation_logic
branch
from
e14bc55
to
b94c66d
Compare
|
@dpressle, we have issue with the CI for some reason for Bashar commits, can you look? |
|
bot:retest |
|
@BasharRadya, please check why tests are failing. |
|
bot:retest |
AlexanderGrissik
approved these changes
Jul 2, 2024
BasharRadya
force-pushed
the
change_allocation_logic
branch
2 times, most recently
from
c90efbb
to
05c6f96
Compare
|
bot:retest |
4 similar comments
|
bot:retest |
|
bot:retest |
|
bot:retest |
|
bot:retest |
BasharRadya
force-pushed
the
change_allocation_logic
branch
from
05c6f96
to
502fc5c
Compare
|
bot:retest |
BasharRadya
force-pushed
the
change_allocation_logic
branch
4 times, most recently
from
293c4ea
to
19dbc35
Compare
BasharRadya
force-pushed
the
change_allocation_logic
branch
4 times, most recently
from
293c4ea
to
19dbc35
Compare
Modified the default ring allocation logic from ‘ring per interface’ to ‘ring per thread’. Adjusted the MCE_SPEC_NGINX_DPU and MCE_SPEC_NGINX by setting ring_allocation_logic_tx/rx to ‘ring per interface’. Fixed a minor side-effect in the ring_allocation_logic constructor. Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
BasharRadya
force-pushed
the
change_allocation_logic
branch
from
19dbc35
to
357dbd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type
What kind of change does this PR introduce?
Check list