issue: Implement doorbell batching for the new API #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBUF_NONE was used mistakenly instead of PBUF_DESC_NONE. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
The field doesn't have to be initialized if we do copy. This is extra operation, therefore, move it to the else branch. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Inline part of the fill_wqe() is overcomplicated. Hide it in a separate method, so refactoring can be isolated. Also, don't check multiple scatter-gather case for inline criteria. This is unlikely scenario because TCP layer copies non-zcopy data to a single buffer until it's full. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
URGENT flag requests TX completion for the respective WQE. This is required for zerocopy interfaces where user cannot specify the last send operation explicitly. Otherwise, TX completion batching can lead to a dead lock if user stops sending data and waits for the completions. CALLBACK flag requests to call a callback once the buffer is released by XLIO. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
This allows to achieve doorbell batching similar to TX completions batching. XLIO extra socket API provide explicit flush functionality. Such a flush operation will close WQE accumulation session and ring doorbell. This guarantees doorbells and zcopy completions even if user stops sending data (as far as user calls the final flush). Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New API requires user to call explicit flush. We can implement doorbell batching and close unfinished batch by the flush. This will guarantee doorbell and zcopy completions progress even if user stops sending data.
What
Implement doorbell batching for the new API.
Why ?
Up to 4% performance improvement depending on scenario.
Change type
What kind of change does this PR introduce?
Check list