Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor min max #14

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Refactor min max #14

merged 1 commit into from
Aug 22, 2024

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Aug 21, 2024 •
edited
Loading

only last commit is relevant

@coveralls
Copy link

coveralls commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10511102650

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.209%
Totals Coverage Status
Change from base Build 10503548688: 0.0%
Covered Lines: 999
Relevant Lines: 1532
💛 - Coveralls

ykulazhenkov
ykulazhenkov reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris
change min max util funcs to generic
040f9a9 
Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris
Copy link
Collaborator Author

rebased, merging once CI is green.

@adrianchiris adrianchiris merged commit c86927f into Mellanox:main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykulazhenkov ykulazhenkov ykulazhenkov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianchiris @coveralls @ykulazhenkov