Create minikube dev env #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adrianc <adrianc@nvidia.com>
|
@ykulazhenkov PTAL. plan is to later extend to support multi-node env. |
Pull Request Test Coverage Report for Build 9796841535Details
💛 - Coveralls |
adrianchiris
force-pushed
the
create-minikube-dev-env
branch
from
a5e54c2
to
9b1d381
Compare
Pull Request Test Coverage Report for Build 9797033198Details
💛 - Coveralls |
ykulazhenkov
approved these changes
Jul 4, 2024
| resourceName: maintenance-operator-controller-manager | ||
| namespace: maintenance-operator-system | ||
| port: 56268 | ||
| localPort: 8082 |
There was a problem hiding this comment.
Can you clarify how this portForward is used?
There was a problem hiding this comment.
thats for connecting remote debugger
note: ATM skaffold only works with single node env Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
create-minikube-dev-env
branch
from
9b1d381
to
50f7d25
Compare
Pull Request Test Coverage Report for Build 9826342546Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.