Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance operator config api #3

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add maintenance operator config api #3

merged 2 commits into from
Jul 9, 2024

Conversation

adrianchiris
Copy link
Collaborator

No description provided.

@adrianchiris
Add MaintenanceOperatorConfig CRD skaffolding
8d926c4 
Signed-off-by: adrianc <adrianc@nvidia.com>
@coveralls
Copy link

coveralls commented Jul 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9828514479

Details

  • 9 of 156 (5.77%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 2.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/maintenanceoperatorconfig_controller.go 6 11 54.55%
cmd/maintenance-manager/main.go 0 7 0.0%
api/v1alpha1/zz_generated.deepcopy.go 0 135 0.0%
Files with Coverage Reduction New Missed Lines %
api/v1alpha1/zz_generated.deepcopy.go 1 0.0%
Totals Coverage Status
Change from base Build 9826381325: 1.8%
Covered Lines: 12
Relevant Lines: 407
💛 - Coveralls

ykulazhenkov
ykulazhenkov reviewed Jul 8, 2024
View reviewed changes
api/v1alpha1/maintenanceoperatorconfig_types.go Show resolved Hide resolved
api/v1alpha1/nodemaintenance_types.go Outdated Show resolved Hide resolved
api/v1alpha1/nodemaintenance_types.go Outdated Show resolved Hide resolved
@adrianchiris
Add NodeMaintenance APIs
cb8adc9 
- Add NodeMaintenanceOperatorConfig CRD
- Add NodeMaintenance CRD

Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris adrianchiris force-pushed the add-maintenance-operator-config-api branch from 2d63eaf to cb8adc9 Compare July 9, 2024 09:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9854150328

Details

  • 9 of 156 (5.77%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 2.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/maintenanceoperatorconfig_controller.go 6 11 54.55%
cmd/maintenance-manager/main.go 0 7 0.0%
api/v1alpha1/zz_generated.deepcopy.go 0 135 0.0%
Files with Coverage Reduction New Missed Lines %
api/v1alpha1/zz_generated.deepcopy.go 1 0.0%
Totals Coverage Status
Change from base Build 9826381325: 1.8%
Covered Lines: 12
Relevant Lines: 407
💛 - Coveralls

@ykulazhenkov ykulazhenkov self-requested a review July 9, 2024 12:45
ykulazhenkov
ykulazhenkov approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov merged commit 6a4d7fa into Mellanox:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianchiris @coveralls @ykulazhenkov