Skip to content

Commit

Permalink
chore: Bump operator-sdk and controller-tools (#760)
Browse files Browse the repository at this point in the history
This is a bump of controller tools and `operator-sdk` to their most
recent versions. The resulting changes are minor.

This PR also contains a base commit to regenerate the `operator-sdk`
bundle to separate out changes resulting from the version bump from
those resulting from the regeneration.

This commit was done after running: `DEFAULT_CHANNEL=v23.10.0
CHANNELS=v23.10.0 VERSION=23.10.0 TAG=network-operator:latest make
bundle`. Changes in the `config` folder were excluded.
  • Loading branch information
adrianchiris committed Jan 17, 2024
2 parents d1593a4 + 685039d commit 5e566cd
Show file tree
Hide file tree
Showing 16 changed files with 982 additions and 533 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ $(GOLANGCI_LINT):
# controller gen is used to generate manifests and code for Kubernetes controllers.
CONTROLLER_GEN_PKG = sigs.k8s.io/controller-tools/cmd/controller-gen
CONTROLLER_GEN_BIN = controller-gen
CONTROLLER_GEN_VER = v0.13.0
CONTROLLER_GEN_VER = v0.14.0
CONTROLLER_GEN = $(TOOLSDIR)/$(CONTROLLER_GEN_BIN)-$(CONTROLLER_GEN_VER)
$(CONTROLLER_GEN):
$(call go-install-tool,$(CONTROLLER_GEN_PKG),$(CONTROLLER_GEN_BIN),$(CONTROLLER_GEN_VER))
Expand Down Expand Up @@ -167,7 +167,7 @@ $(HELM): | $(TOOLSDIR)
# operator-sdk is used to generate operator-sdk bundles
OPERATOR_SDK_DL_URL=https://github.com/operator-framework/operator-sdk/releases/download
OPERATOR_SDK_BIN = operator-sdk
OPERATOR_SDK_VER = v1.23.0
OPERATOR_SDK_VER = v1.33.0
OPERATOR_SDK = $(abspath $(TOOLSDIR)/$(OPERATOR_SDK_BIN)-$(OPERATOR_SDK_VER))
$(OPERATOR_SDK): | $(TOOLSDIR)
$Q echo "Installing $(OPERATOR_SDK_BIN)-$(OPERATOR_SDK_VER) to $(TOOLSDIR)"
Expand Down
6 changes: 3 additions & 3 deletions bundle.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1
LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=nvidia-network-operator
LABEL operators.operatorframework.io.bundle.channels.v1=v23.7.0
LABEL operators.operatorframework.io.bundle.channel.default.v1=v23.7.0
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.22.0
LABEL operators.operatorframework.io.bundle.channels.v1=23.10.0-1
LABEL operators.operatorframework.io.bundle.channel.default.v1=23.10.0-1
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.33.0
LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1
LABEL operators.operatorframework.io.metrics.project_layout=go.kubebuilder.io/v3

Expand Down
4 changes: 2 additions & 2 deletions bundle/manifests/mellanox.com_hostdevicenetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.10.0
controller-gen.kubebuilder.io/version: v0.13.0
creationTimestamp: null
name: hostdevicenetworks.mellanox.com
spec:
Expand Down Expand Up @@ -63,7 +63,7 @@ spec:
name:
type: string
state:
description: Represents reconcile state of the system
description: State represents reconcile state of the system.
enum:
- ready
- notReady
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/mellanox.com_ipoibnetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.10.0
controller-gen.kubebuilder.io/version: v0.13.0
creationTimestamp: null
name: ipoibnetworks.mellanox.com
spec:
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/mellanox.com_macvlannetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.10.0
controller-gen.kubebuilder.io/version: v0.13.0
creationTimestamp: null
name: macvlannetworks.mellanox.com
spec:
Expand Down
371 changes: 365 additions & 6 deletions bundle/manifests/mellanox.com_nicclusterpolicies.yaml

Large diffs are not rendered by default.

41 changes: 27 additions & 14 deletions bundle/manifests/nvidia-network-operator.clusterserviceversion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metadata:
},
"spec": {
"ofedDriver": {
"image": "mofed",
"image": "doca-driver",
"livenessProbe": {
"initialDelaySeconds": 30,
"periodSeconds": 30
Expand All @@ -76,7 +76,7 @@ metadata:
},
"maxParallelUpgrades": 1
},
"version": "23.10-0.2.8.0"
"version": "24.01-0.1.7.0"
},
"rdmaSharedDevicePlugin": {
"config": "{\n \"configList\": [\n {\n \"resourceName\": \"rdma_shared_device_a\",\n \"rdmaHcaMax\": 63,\n \"selectors\": {\n \"vendors\": [\"15b3\"]\n }\n }\n ]\n}\n",
Expand All @@ -88,14 +88,15 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2024-01-17T13:39:15Z"
description: Deploy and manage NVIDIA networking resources in Kubernetes
operatorframework.io/suggested-namespace: nvidia-network-operator
operators.operatorframework.io/builder: operator-sdk-v1.22.0
operators.operatorframework.io/builder: operator-sdk-v1.33.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
provider: NVIDIA
repository: https://github.com/Mellanox/network-operator/
support: NVIDIA
name: nvidia-network-operator.v24.1.0
name: nvidia-network-operator.v23.10.0-1
namespace: placeholder
spec:
apiservicedefinitions: {}
Expand Down Expand Up @@ -310,6 +311,14 @@ spec:
- create
- patch
- update
- apiGroups:
- image.openshift.io
resources:
- imagestreams
verbs:
- get
- list
- watch
- apiGroups:
- k8s.cni.cncf.io
resources:
Expand Down Expand Up @@ -542,9 +551,11 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: USE_DTK
value: "true"
- name: OFED_INIT_CONTAINER_IMAGE
value: ghcr.io/mellanox/network-operator-init-container:v0.0.2
image: nvcr.io/nvidia/cloud-native/network-operator@sha256:7005fa24a1ae52d927e76d50d90fddf6b6c7b08885a2dad3c7e5e2c2ac21c834
image: network-operator@sha256:e9cf9a438be8cfb7472998abef55f1ace964dae7f9043a697fabcae751eb96e3
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
Expand Down Expand Up @@ -651,7 +662,7 @@ spec:
provider:
name: NVIDIA
url: https://github.com/Mellanox/network-operator/
version: 24.1.0
version: 23.10.0-1
webhookdefinitions:
- admissionReviewVersions:
- v1
Expand Down Expand Up @@ -694,11 +705,13 @@ spec:
type: ValidatingAdmissionWebhook
webhookPath: /validate-mellanox-com-v1alpha1-nicclusterpolicy
relatedImages:
- image: nvcr.io/nvidia/mellanox/mofed@sha256:a0c4562af2d25f87f5b37e53b6e4085559dfeed873279c77a355f7ad738afb60
name: mofed
- image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin@sha256:f717f9778f48665b7c592f2225df51b755a1fe048125e034a286c564ee10fd37
name: sriov-network-device-plugin
- image: nvcr.io/nvidia/cloud-native/k8s-rdma-shared-dev-plugin@sha256:941ad9ff5013e9e7ad5abeb0ea9f79d45379cfae88a628d923f87d2259bdd132
name: rdma-shared-device-plugin
- image: nvcr.io/nvidia/cloud-native/network-operator@sha256:7005fa24a1ae52d927e76d50d90fddf6b6c7b08885a2dad3c7e5e2c2ac21c834
name: network-operator
- image: nvcr.io/nvidia/mellanox/mofed@sha256:ada9d1c4bf8eda0d6b76f2d3c0f67c9cd6862284f1312c6a6f142d5c217543b4
name: mofed
- image: ghcr.io/k8snetworkplumbingwg/sriov-network-device-plugin@sha256:f717f9778f48665b7c592f2225df51b755a1fe048125e034a286c564ee10fd37
name: sriov-network-device-plugin
- image: nvcr.io/nvidia/cloud-native/k8s-rdma-shared-dev-plugin@sha256:941ad9ff5013e9e7ad5abeb0ea9f79d45379cfae88a628d923f87d2259bdd132
name: rdma-shared-device-plugin
- image: gcr.io/kubebuilder/kube-rbac-proxy@sha256:db06cc4c084dd0253134f156dddaaf53ef1c3fb3cc809e5d81711baa4029ea4c
name: kube-rbac-proxy
- image: nvcr.io/nvidia/cloud-native/network-operator@sha256:e9cf9a438be8cfb7472998abef55f1ace964dae7f9043a697fabcae751eb96e3
name: network-operator
7 changes: 3 additions & 4 deletions bundle/metadata/annotations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ annotations:
operators.operatorframework.io.bundle.manifests.v1: manifests/
operators.operatorframework.io.bundle.metadata.v1: metadata/
operators.operatorframework.io.bundle.package.v1: nvidia-network-operator
operators.operatorframework.io.bundle.channels.v1: v23.7.0
operators.operatorframework.io.bundle.channel.default.v1: v23.7.0
operators.operatorframework.io.metrics.builder: operator-sdk-v1.22.0
operators.operatorframework.io.bundle.channels.v1: 23.10.0-1
operators.operatorframework.io.bundle.channel.default.v1: 23.10.0-1
operators.operatorframework.io.metrics.builder: operator-sdk-v1.33.0
operators.operatorframework.io.metrics.mediatype.v1: metrics+v1
operators.operatorframework.io.metrics.project_layout: go.kubebuilder.io/v3

com.redhat.openshift.versions: v4.10-4.14
# Annotations for testing.
operators.operatorframework.io.test.mediatype.v1: scorecard+v1
operators.operatorframework.io.test.config.v1: tests/scorecard/
19 changes: 12 additions & 7 deletions config/crd/bases/mellanox.com_hostdevicenetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.14.0
name: hostdevicenetworks.mellanox.com
spec:
group: mellanox.com
Expand All @@ -27,14 +27,19 @@ spec:
description: HostDeviceNetwork is the Schema for the hostdevicenetworks API
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand Down
19 changes: 12 additions & 7 deletions config/crd/bases/mellanox.com_ipoibnetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.14.0
name: ipoibnetworks.mellanox.com
spec:
group: mellanox.com
Expand All @@ -27,14 +27,19 @@ spec:
description: IPoIBNetwork is the Schema for the ipoibnetworks API
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand Down
19 changes: 12 additions & 7 deletions config/crd/bases/mellanox.com_macvlannetworks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.14.0
name: macvlannetworks.mellanox.com
spec:
group: mellanox.com
Expand All @@ -27,14 +27,19 @@ spec:
description: MacvlanNetwork is the Schema for the macvlannetworks API
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand Down
Loading

0 comments on commit 5e566cd

Please sign in to comment.