Skip to content

Commit

Permalink
Enable NodeFeatureApi in NFD and run the NFD with default annotation ns
Browse files Browse the repository at this point in the history
This patch does the following:
 - Set enableNodeFeatureApi to true by default
 - Run the NFD with default annotation namespace
 - Enhance READE NFD documentation

Signed-off-by: Waleed Mousa <waleedm@nvidia.com>
  • Loading branch information
wmousa committed Jul 10, 2023
1 parent b83f735 commit c1f694b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ __Example NFD worker configurations:__
>\* Required for GPUDirect driver container deployment
If NFD is already deployed in the cluster, make sure to pass `--set nfd.enabled=false` to the helm install command to avoid conflicts.
>__NOTE__: If NFD is already deployed in the cluster, make sure to pass `--set nfd.enabled=false` to the helm install command to avoid conflicts,
and if NFD is deployed from this repo the `enableNodeFeatureApi` flag is enabled by default to have the ability to create NodeFeatureRules.

## Resource Definitions
The Operator Acts on the following CRDs:
Expand Down
3 changes: 1 addition & 2 deletions deployment/network-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ sriovNetworkOperator:

# Node Feature discovery chart related values
node-feature-discovery:
enableNodeFeatureApi: false
enableNodeFeatureApi: true
worker:
serviceAccount:
name: node-feature-discovery
Expand Down Expand Up @@ -60,7 +60,6 @@ node-feature-discovery:
deviceLabelFields:
- vendor
master:
instance: "nvidia.networking"
serviceAccount:
name: node-feature-discovery
create: true
Expand Down
3 changes: 1 addition & 2 deletions hack/templates/values/values.template
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ sriovNetworkOperator:

# Node Feature discovery chart related values
node-feature-discovery:
enableNodeFeatureApi: false
enableNodeFeatureApi: true
worker:
serviceAccount:
name: node-feature-discovery
Expand Down Expand Up @@ -60,7 +60,6 @@ node-feature-discovery:
deviceLabelFields:
- vendor
master:
instance: "nvidia.networking"
serviceAccount:
name: node-feature-discovery
create: true
Expand Down

0 comments on commit c1f694b

Please sign in to comment.