-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors are not reported in CR status #533
Labels
Comments
adrianchiris
added
bug
Something isn't working
priority-high
priority-medium
and removed
priority-high
labels
May 23, 2023
rollandf
added a commit
to rollandf/network-operator
that referenced
this issue
Apr 17, 2024
Fixes Mellanox#533 Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf
added a commit
to rollandf/network-operator
that referenced
this issue
May 15, 2024
Fixes Mellanox#533 Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf
added a commit
to rollandf/network-operator
that referenced
this issue
May 23, 2024
Fixes Mellanox#533 Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf
added a commit
to rollandf/network-operator
that referenced
this issue
May 27, 2024
Fixes Mellanox#533 Signed-off-by: Fred Rolland <frolland@nvidia.com>
adrianchiris
added a commit
that referenced
this issue
May 28, 2024
Fixes #533 Example status: ``` status: appliedStates: - name: state-multus-cni state: ignore - name: state-container-networking-plugins state: ignore - name: state-ipoib-cni state: ignore - name: state-whereabouts-cni state: ignore - error: 'failed to create k8s objects from manifest: failed to render objects: ForcePrecompiled is enabled and precompiled image was not found' name: state-OFED state: notReady - name: state-SRIOV-device-plugin state: ignore ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
if an error occurs when syncing state, we should update global status with the first error encountered (in controller)
while this is true for some controllers, it is not for others
in addition the different states in most cases that an error occured return
SyncStateNotReady
instead ofSyncStateError
this should be reviewed and fixed for all states.
The text was updated successfully, but these errors were encountered: