fix: Add field in the nicclusterpolicy helm template for nodeAffinity #349
Conversation
|
|
slu2011
changed the title
|
Signed off by @e0ne @adrianchiris |
|
@slu2011 Thanks for the PR! You need to update the GIT commit message with a signed-off-by line with your name and your email address. For example: |
slu2011
force-pushed
the
master
branch
4 times, most recently
from
5b23544
to
a66ca7f
Compare
|
Thanks @rollandf for your help. Can you please review the MR? Or mention the folks who would be appropriate. |
|
/retest-nic_operator_kind |
|
Hi, Can you also document this new helm parameter https://github.com/Mellanox/network-operator/blob/master/deployment/network-operator/README.md under "chart parameters" |
slu2011
force-pushed
the
master
branch
2 times, most recently
from
a77f539
to
8816825
Compare
|
/retest-all |
|
/retest-image_scan |
1 similar comment
|
/retest-image_scan |
| See [Kubernetes Node Affinity](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/) | ||
|
|
||
|
|
||
| | Name | Type | Default | description | |
There was a problem hiding this comment.
nit: you can just add the parameter to the table in ### General parameters
currently this section is added is under "secondary network" however node affinity also applies to OFED driver container as well
There was a problem hiding this comment.
Hi @adrianchiris can you please take a look again?
|
/retest-image_scan |
|
@slu2011 ping :) i think we are really close to merging this one, just a minor comment. |
|
@slu2011 , please also squash the commits into a single one. |
This is for mitigating Mellanox#310. We can override the default node effinity which would prevent deploying on master nodes. Signed-off-by: shil <shil@nvidia.com>
|
/retest-nic_operator_kind |
|
Hi @adrianchiris @rollandf can you please take a look again? Thanks a lot! |
|
done, thanks for working on it ! |
fix: Add field in the nicclusterpolicy helm template to allow setting the nodeAffinity field
related issue: #310