Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPoIB Network support #350

Merged
merged 1 commit into from
Jun 14, 2022
Merged

IPoIB Network support #350

merged 1 commit into from
Jun 14, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented May 16, 2022

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented May 16, 2022

This pull request introduces 2 alerts when merging c532225 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 16, 2022

This pull request introduces 2 alerts when merging 132a8df into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 16, 2022

This pull request introduces 2 alerts when merging d395163 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@e0ne e0ne marked this pull request as ready for review May 19, 2022 10:26
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 2 alerts when merging 0c85f72 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 2 alerts when merging e114aec into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 2 alerts when merging 882f411 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request introduces 2 alerts when merging 5d94910 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 2 alerts when merging 5208f3b into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 2 alerts when merging 9172b96 into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2022

This pull request introduces 2 alerts when merging 2e98eef into 0d7af35 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

rollandf
rollandf reviewed May 25, 2022
View reviewed changes
controllers/ipoibnetwork_controller.go Outdated Show resolved Hide resolved
controllers/ipoibnetwork_controller.go Outdated Show resolved Hide resolved
pkg/state/state_ipoib_cni_test.go Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 30, 2022

This pull request introduces 2 alerts when merging e8774b8 into df09fe9 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@lgtm-com
Copy link

lgtm-com bot commented May 30, 2022

This pull request introduces 2 alerts when merging e14942d into b44d12b - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@rollandf
Copy link
Member

Looks good.
Can you add also an example here: https://github.com/Mellanox/network-operator/tree/master/config/samples
And add also the new CRD here: https://github.com/Mellanox/network-operator/blob/master/config/manifests/bases/nvidia-network-operator.clusterserviceversion.yaml#L17

@e0ne
Copy link
Collaborator Author

e0ne commented May 31, 2022

Looks good. Can you add also an example here: https://github.com/Mellanox/network-operator/tree/master/config/samples And add also the new CRD here: https://github.com/Mellanox/network-operator/blob/master/config/manifests/bases/nvidia-network-operator.clusterserviceversion.yaml#L17

done

@lgtm-com
Copy link

lgtm-com bot commented May 31, 2022

This pull request introduces 2 alerts when merging 475aee3 into b44d12b - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

@rollandf
Copy link
Member

LGTM

@e0ne
Copy link
Collaborator Author

e0ne commented May 31, 2022

/retest-nic_operator_helm

1 similar comment
@e0ne
Copy link
Collaborator Author

e0ne commented May 31, 2022

/retest-nic_operator_helm

adrianchiris
adrianchiris reviewed Jun 1, 2022
View reviewed changes
config/samples/kustomization.yaml Outdated Show resolved Hide resolved
controllers/ipoibnetwork_controller.go Outdated Show resolved Hide resolved
controllers/ipoibnetwork_controller_test.go Show resolved Hide resolved
manifests/stage-ipoib-cni/0040-ipoib-cni-ds.yml Outdated Show resolved Hide resolved
pkg/state/state_test.go Outdated Show resolved Hide resolved
pkg/state/state_test.go Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2022

This pull request introduces 2 alerts when merging be76668 into 6626a30 - view on LGTM.com

new alerts:

  • 2 for Wrapped error is always nil

adrianchiris
adrianchiris reviewed Jun 7, 2022
View reviewed changes
controllers/ipoibnetwork_controller.go Outdated Show resolved Hide resolved
controllers/ipoibnetwork_controller.go Show resolved Hide resolved
deployment/network-operator/values.yaml Show resolved Hide resolved
manifests/stage-ipoib-cni/0010-ipoib-cni-ds.yml Show resolved Hide resolved
pkg/state/state_ipoib_network_test.go Outdated Show resolved Hide resolved
pkg/state/state_ipoib_network_test.go Outdated Show resolved Hide resolved
@e0ne
Copy link
Collaborator Author

e0ne commented Jun 8, 2022

/retest-image_scan

@e0ne
Implement IPoIBNetwork support
444857b 
This patch adds IPoIB CNI support and introduces
following changes:

* Add IPoIBNetwork controller and related states
* Extends NicClusterPolicy to deploy mellanox/ipoib-cni
* Update examples for Kubernetes and OCP

Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
@adrianchiris adrianchiris merged commit 0eeb3d3 into Mellanox:master Jun 14, 2022
@e0ne e0ne mentioned this pull request Jun 15, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollandf rollandf rollandf left review comments

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e0ne @rollandf @adrianchiris