Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OCP deployment examples with OFED upgradePolicy #390

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jul 20, 2022

We need to set deleteEmptyDir=true and force=true for node draining
settings to work with default OCP installation.

Signed-off-by: Ivan Kolodiazhnyi ikolodiazhny@nvidia.com

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next step is to decide if we are going to enable this feature by default

@adrianchiris
Copy link
Collaborator

@e0ne we can update mofed version in a follwup PR if you wish (might as well bump it to 5.7 once released)

feel free to merge this one if you agree with the above statement

We need to set deleteEmptyDir=true and force=true for node draining
settings to work with default OCP installation.

This patch also bumps MOFED version in examples.

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@e0ne e0ne merged commit 9966604 into Mellanox:master Jul 25, 2022
@e0ne e0ne mentioned this pull request Jul 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants