-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable security context for ipoib-cni in OCP #413
Conversation
/retest-all |
dff83a7
to
7b6fc41
Compare
afea455
to
9358357
Compare
@@ -0,0 +1,49 @@ | |||
{{if eq .RuntimeSpec.OSName "rhcos"}} | |||
# Please edit the object below. Lines beginning with a '#' will be ignored, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For me it is a bit easier to read specs if yaml keys are ordered with k8s style:
apiVersion:
kind:
metadata:
..other fields
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a common format for OCP Security Context Constraints: https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html
We use the same format for all other states.
We can change but for consistency it needs to be done for all similar files in the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's keep it as is
Add service account, role and securityContextConstraints. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
9358357
to
c343652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge it after testing
Add service account, role and securityContextConstraints
Signed-off-by: amaslennikov amaslennikov@nvidia.com