Enable security context for ipoib-cni in OCP #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-all |
almaslennikov
force-pushed
the
ipoib_cni_openshift
branch
from
dff83a7
to
7b6fc41
Compare
e0ne
requested changes
Oct 7, 2022
almaslennikov
force-pushed
the
ipoib_cni_openshift
branch
2 times, most recently
from
afea455
to
9358357
Compare
| @@ -0,0 +1,49 @@ | |||
| {{if eq .RuntimeSpec.OSName "rhcos"}} | |||
| # Please edit the object below. Lines beginning with a '#' will be ignored, | |||
There was a problem hiding this comment.
nit: For me it is a bit easier to read specs if yaml keys are ordered with k8s style:
apiVersion:
kind:
metadata:
..other fields
WDYT?
There was a problem hiding this comment.
This appears to be a common format for OCP Security Context Constraints: https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html
We use the same format for all other states.
We can change but for consistency it needs to be done for all similar files in the project
There was a problem hiding this comment.
Ok, let's keep it as is
ykulazhenkov
approved these changes
Oct 11, 2022
Add service account, role and securityContextConstraints. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
ipoib_cni_openshift
branch
from
9358357
to
c343652
Compare
e0ne
approved these changes
Oct 13, 2022
e0ne
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service account, role and securityContextConstraints
Signed-off-by: amaslennikov amaslennikov@nvidia.com