Watch for node label change event in NicClusterPolicy reconcile loop #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0ne
commented
Oct 23, 2022
| } | ||
|
|
||
| createEnqueue := handler.Funcs{ | ||
| CreateFunc: func(e event.CreateEvent, q workqueue.RateLimitingInterface) { |
There was a problem hiding this comment.
This won't work. We need to add label after NFD applied feature.node.kubernetes.io/pci-15b3.present label
There was a problem hiding this comment.
so it means you need to watch on just updates or create & update IMO
| IsController: true, | ||
| OwnerType: &mellanoxv1alpha1.NicClusterPolicy{}, | ||
| }) | ||
| }).Watches(&source.Kind{Type: &corev1.Node{}}, createEnqueue, nodePredicates) |
There was a problem hiding this comment.
i think you would want to add this (watching on nodes) only once ?
| } | ||
|
|
||
| createEnqueue := handler.Funcs{ | ||
| CreateFunc: func(e event.CreateEvent, q workqueue.RateLimitingInterface) { |
There was a problem hiding this comment.
so it means you need to watch on just updates or create & update IMO
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
bf94fa9
to
7cf4323
Compare
e0ne
changed the title
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
7cf4323
to
6fc9863
Compare
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
6fc9863
to
94b2c34
Compare
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
94b2c34
to
ea55907
Compare
adrianchiris
approved these changes
Oct 26, 2022
ykulazhenkov
approved these changes
Oct 26, 2022
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
ea55907
to
a7f0a63
Compare
We need to watch for node create event for correct cluster scale up by adding 'network.nvidia.com/operator.mofed.wait' label. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
e0ne
force-pushed
the
nic-cluster-policy-node-reconcile
branch
from
a7f0a63
to
29efa09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to watch for node create event for correct cluster scale up by adding 'network.nvidia.com/operator.mofed.wait' label.
Signed-off-by: Ivan Kolodiazhny ikolodiazhny@nvidia.com