-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-build make target #450
Conversation
@e0ne what is the downside of using kustomize for it ? as its a standard tool that will work for this use-case |
I didn't know that. If it's common-used not only for OCP I have no objections to use it. My original idea was to create simle binary just to render templates with few fields and do not introduce any 3rd-party dependency for this script |
16d942f
to
c82fb33
Compare
/retest-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that bothers me is that we are mixing the location of templates and the rendered files.
maybe split the two ?
generated files can be written to their original place but we can put templates in a separate folder WDYT ?
currently its a bit confusing to me.
hack/release.go
Outdated
initWithEnvVariale("IPAM_PLUGIN", release.Ipoib) | ||
} | ||
|
||
func main2() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this one ?
hack/release.go
Outdated
} | ||
|
||
func readDefaults() Release { | ||
f, err := os.ReadFile("release.yaml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this path configurable (with default value) via cmdine flag ?
hack/release.go
Outdated
} | ||
|
||
func main() { | ||
templates := flag.String("templates", ".", "Directory with templates to render") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: templateDir ?
hack/release.go
Outdated
fmt.Printf("Error: %v\n", err) | ||
return | ||
} | ||
// Print out the template to std |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is wrong here, perhaps just remove it ?
New make target changes Network Operator and MOFED images data in examples, helm chart and OCP bundle. Simple golang binary is used instead of kustomize to minimize support effort. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of nits, otherwise LGTM.
@e0ne do you think its worth adding a GA check to ensure changes were not introduced manually ?
that is a check that will:
- run make release-build
- make sure no diffs
different PR is fine, thx. |
New make target changes Network Operator and MOFED images data in examples, helm chart and OCP bundle.
Simple golang binary is used instead of kustomize to minimize support effort.
Signed-off-by: Ivan Kolodiazhny ikolodiazhny@nvidia.com