Add support for CRD upgrade with Helm pre-upgrade hook #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
force-pushed
the
auto-crd-upgrade
branch
from
9ed50c5
to
1f8cdb5
Compare
Dockerfile
Outdated
|
|
||
| # Add helm chart DIR to get CRDs from it | ||
| COPY deployment/network-operator chart | ||
| # Update helm dependencies and copy CRDs from them |
There was a problem hiding this comment.
nit: there is no update of helm dependencies here
There was a problem hiding this comment.
Correct. I updated the docstring. Update here will be required after we will upgrade the version of the NFD chart
| @@ -183,22 +183,6 @@ helm search repo mellanox/network-operator -l | |||
|
|
|||
| > __NOTE__: add `--devel` option if you want to list beta releases as well | |||
|
|
|||
| ### Download CRDs for the specific release | |||
There was a problem hiding this comment.
Im thinking we should still keep a section about upgrading CRDs.
we should have two subsections
- manual upgrade (what we have here)
- automatic upgrade using helm chart by setting .Values.upgradeCRDs to true
There was a problem hiding this comment.
I changed this section to keep info about manual process
ykulazhenkov
force-pushed
the
auto-crd-upgrade
branch
3 times, most recently
from
06a8774
to
182de23
Compare
adrianchiris
approved these changes
May 16, 2023
rollandf
approved these changes
May 16, 2023
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
auto-crd-upgrade
branch
from
182de23
to
43ace75
Compare
|
Latest released kubectl has known security issue which is detected by image_scan job. Need to wait for new kubectl release (the issue is already fixed in master) |
ykulazhenkov
changed the title
rollandf
added
the
on hold
|
/retest-image_scan |
ykulazhenkov
changed the title
ykulazhenkov
removed
the
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR contains two changes: