-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CRD upgrade with Helm pre-upgrade hook #526
Conversation
9ed50c5
to
1f8cdb5
Compare
Dockerfile
Outdated
|
||
# Add helm chart DIR to get CRDs from it | ||
COPY deployment/network-operator chart | ||
# Update helm dependencies and copy CRDs from them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there is no update of helm dependencies here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I updated the docstring. Update here will be required after we will upgrade the version of the NFD chart
@@ -183,22 +183,6 @@ helm search repo mellanox/network-operator -l | |||
|
|||
> __NOTE__: add `--devel` option if you want to list beta releases as well | |||
|
|||
### Download CRDs for the specific release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im thinking we should still keep a section about upgrading CRDs.
we should have two subsections
- manual upgrade (what we have here)
- automatic upgrade using helm chart by setting .Values.upgradeCRDs to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this section to keep info about manual process
06a8774
to
182de23
Compare
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
182de23
to
43ace75
Compare
Latest released kubectl has known security issue which is detected by image_scan job. Need to wait for new kubectl release (the issue is already fixed in master) |
/retest-image_scan |
This MR contains two changes: