Watch ConfigMap changes for related states #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
changed the title
adrianchiris
changed the title
adrianchiris
added
the
on hold
ykulazhenkov
approved these changes
Jun 26, 2023
Currently config map changes will not trigger reconcile. Add ConfigMap as watched resource for nicclusterpolicy controller for the following states: - nv-ipam - multus-cni - rdma-device-plugin - sriov-device-plugin Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
add-config-map-to-watch
branch
from
28996f4
to
600c2bf
Compare
adrianchiris
removed
the
on hold
|
@ykulazhenkov @rollandf PTAL, i found that a few other states were missing watch for configmap. p.s |
adrianchiris
changed the title
ykulazhenkov
approved these changes
Jun 28, 2023
|
LGTM, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently config map changes will not trigger reconcile. Add ConfigMap as watched resource for nicclusterpolicy controller using nv-ipam state.