Drop MOFED support older than 5.7-0.1.2.0 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-nic_operator_kind |
|
please add more info in each commit message.
|
| cr.Spec.OFEDDriver.Version = "5.6-1.0.0.0" | ||
| imageName := stateOfed.getMofedDriverImageName(cr, nodeAttr, testLogger) | ||
| Expect(imageName).To(Equal("nvcr.io/mellanox/mofed-5.6-1.0.0.0:ubuntu20.04-amd64")) | ||
| }) | ||
| It("generates new image format", func() { |
pkg/nodeinfo/attributes.go
Outdated
| @@ -63,6 +65,8 @@ var attrToLabel = []string{ | |||
| NodeLabelOSName, | |||
| // AttrTypeOSVer | |||
| NodeLabelOSVer, | |||
| // AttrTypeOSVerMajor | |||
| NodeLabelCudaVersionMajor, | |||
pkg/state/state_ofed.go
Outdated
| osName := nodeAttr[nodeinfo.AttrTypeOSName] | ||
| osVer := nodeAttr[nodeinfo.AttrTypeOSVer] | ||
| if curDriverVer != nil && curDriverVer.GreaterThan(oldRhelFormatDriverVer) && osName == rhelOSName { | ||
| osVer = nodeAttr[nodeinfo.AttrTypeOSVerMajor] + ".x" |
There was a problem hiding this comment.
I asked Vlad to tag (re-tag) each version explicitly why do we need this.
in addition IF we will need a special version for a specific RHEL release we will loose the ability to do it.
There was a problem hiding this comment.
@e0ne i think we should try to keep a single format in network operator.
MOFED driver container can be re-tagged as needed for multiple OS versions
We don't need to support old MOFED version in the latest Network Operator release. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
e0ne
changed the title
adrianchiris
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.