-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop MOFED support older than 5.7-0.1.2.0 #566
Conversation
/retest-nic_operator_kind |
please add more info in each commit message.
|
cr.Spec.OFEDDriver.Version = "5.6-1.0.0.0" | ||
imageName := stateOfed.getMofedDriverImageName(cr, nodeAttr, testLogger) | ||
Expect(imageName).To(Equal("nvcr.io/mellanox/mofed-5.6-1.0.0.0:ubuntu20.04-amd64")) | ||
}) | ||
It("generates new image format", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: drop the "new"
pkg/nodeinfo/attributes.go
Outdated
@@ -63,6 +65,8 @@ var attrToLabel = []string{ | |||
NodeLabelOSName, | |||
// AttrTypeOSVer | |||
NodeLabelOSVer, | |||
// AttrTypeOSVerMajor | |||
NodeLabelCudaVersionMajor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate ?
pkg/state/state_ofed.go
Outdated
osName := nodeAttr[nodeinfo.AttrTypeOSName] | ||
osVer := nodeAttr[nodeinfo.AttrTypeOSVer] | ||
if curDriverVer != nil && curDriverVer.GreaterThan(oldRhelFormatDriverVer) && osName == rhelOSName { | ||
osVer = nodeAttr[nodeinfo.AttrTypeOSVerMajor] + ".x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked Vlad to tag (re-tag) each version explicitly why do we need this.
in addition IF we will need a special version for a specific RHEL release we will loose the ability to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e0ne i think we should try to keep a single format in network operator.
MOFED driver container can be re-tagged as needed for multiple OS versions
We don't need to support old MOFED version in the latest Network Operator release. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
No description provided.