-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeFeatureRules to label Nvidia NICs #571
Conversation
63b2b75
to
6486b0c
Compare
- "02" | ||
- "0200" | ||
- "0207" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this, in case the users decide to set deployNodeFeatureRules to false. NFD can handle the duplicated config giving NodeFeatureRule priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested to waleed to remove to avoid having duplicate places that label the same thing.
if this is left here, then why create nodefeaturerule by default. i think we want to rely on one mechanism for most cases.
since we may have external NFD deployed (which we require to have nodefeaturerules enabled) which then will require us to use nodefeaturerules created. i prefer to always rely on it.
if user decides to set this one to false, he needs to be aware of the implications. IMO.
in that case the user either:
- has another NFD deployed with all needed configs
- user would need to change this entry to add the values needed
- or simply keep deployNodeFeatureRules true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, Done
we need to add a section in README on the different ways NFD can be deployed.
if externally, we need to specify requirements. i.e version, expected features to be enabled and install example using helm from upstream repo |
ee7cbe0
to
dec8fc4
Compare
This patch does the following: - Add "Nvidia NICs PCI" NFR to lable the node with `pci-15b3.present": "true"` if any of Nvidia NICs is exist - Add nfd.deployNodeFeatureRules flag and set it true by default to allow creating NFRs above - Remove the networking PCI class from the source configuration - Enhance READE documentation Signed-off-by: Waleed Mousa <waleedm@nvidia.com>
This patch does the following:
pci-15b3.present": "true"
if any of Nvidia NICs is existpci-15b3.sriov.capable": "true"
if any of Nvidia NICs has SRIOV enabled