Add default env vars for MOFED container #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created #574 the mofed state file keeps growing, at some point we need to chop it up. |
adrianchiris
force-pushed
the
defaut-ofed-vars
branch
2 times, most recently
from
593efde
to
c4c1d45
Compare
|
@e0ne @ykulazhenkov PTAL, this is needed b4 next beta drop. i also testing this one on kind cluster, it behaves as expected. |
adrianchiris
force-pushed
the
defaut-ofed-vars
branch
from
c4c1d45
to
0429af6
Compare
In case of older distros (kernels), we need to explictly specify CREATE_IFNAMES_UDEV so that netdev names are preserved. when MOFED container loads the driver, it reports additional information to kernel about Nvidia network devices that affect the way the OS names netdevs. On newer distros (kernels) this is not needed as inbox driver already reports this information. Instruct MOFED container to install the "name preserving udev" on the following OSes: rhel < 9.0 ocp < 4.13 ubuntu < 22.04 Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
defaut-ofed-vars
branch
from
0429af6
to
362ef12
Compare
ykulazhenkov
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of older distros (kernels),
we need to explictly specify CREATE_IFNAMES_UDEV
so that netdev names are preserved.
when MOFED container loads the driver, it reports
additional information to kernel about Nvidia network devices that affect the way the OS names netdevs.
On newer distros (kernels) this is not needed as
inbox driver already reports this information.
Instruct MOFED container to install the
"name preserving udev" on the following OSes:
rhel < 9.0
ocp < 4.13
ubuntu < 22.04