Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit maximum number of RDMA resources for Shared Device Plugin #580

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Limit maximum number of RDMA resources for Shared Device Plugin #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["1017"],
Expand Down Expand Up @@ -198,7 +198,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion config/samples/mellanox.com_v1alpha1_nicclusterpolicy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"]
}
Expand Down
2 changes: 2 additions & 0 deletions deployment/network-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,12 @@ resources:
vendors: [15b3]
deviceIDs: [1017]
ifNames: [enp5s0f0]
rdmaHcaMax: 63
- name: rdma_shared_device_b
vendors: [15b3]
deviceIDs: [1017]
ifNames: [ib0, ib1]
rdmaHcaMax: 63
```

#### SR-IOV Network Device plugin
Expand Down
2 changes: 1 addition & 1 deletion deployment/network-operator/templates/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ spec:
{{- range $index, $element := .Values.rdmaSharedDevicePlugin.resources }}
{
"resourceName": {{ $element.name | quote }},
"rdmaHcaMax": 1000,
"rdmaHcaMax": {{ $element.rdmaHcaMax | default 63 }},
"selectors": {
"vendors": {{ $element.vendors | default list | toJson }},
"deviceIDs": {{ $element.deviceIDs | default list | toJson }},
Expand Down
1 change: 1 addition & 0 deletions deployment/network-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ rdmaSharedDevicePlugin:
resources:
- name: rdma_shared_device_a
vendors: [15b3]
rdmaHcaMax: 63

sriovDevicePlugin:
deploy: false
Expand Down
2 changes: 1 addition & 1 deletion example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"]
}
Expand Down
2 changes: 1 addition & 1 deletion example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"]
}
Expand Down
2 changes: 1 addition & 1 deletion hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"],
"deviceIDs": ["101b"]
Expand Down
2 changes: 1 addition & 1 deletion hack/templates/samples/mellanox.com_v1alpha1_nicclusterpolicy.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
"configList": [
{
"resourceName": "rdma_shared_device_a",
"rdmaHcaMax": 1000,
"rdmaHcaMax": 63,
"selectors": {
"vendors": ["15b3"]
}
Expand Down
1 change: 1 addition & 0 deletions hack/templates/values/values.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ rdmaSharedDevicePlugin:
resources:
- name: rdma_shared_device_a
vendors: [15b3]
rdmaHcaMax: 63

sriovDevicePlugin:
deploy: false
Expand Down