Add nic feature discovery #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
changed the title
|
Still need to check this one on openshift cluster |
adrianchiris
force-pushed
the
add-nic-feature-discovery
branch
2 times, most recently
from
31064a6
to
7dd84bf
Compare
This state will deploy nic-feature-discovery daemon - Extend NicClusterPolicy CR with a new `nicFeatureDiscovery` field - Add nic-feature-discovery manifests (yamls) - Implement nic-feature-discovery state Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
add-nic-feature-discovery
branch
from
7dd84bf
to
08838f8
Compare
adrianchiris
changed the title
|
@e0ne @ykulazhenkov PTAL, id like to try and merge this one by EOW. |
ykulazhenkov
reviewed
Sep 6, 2023
manifests/state-nic-feature-discovery/030-nic-feature-discovery-ds.yaml
Outdated
Show resolved
Hide resolved
Update Helm chart and templates tot support nic-feature-discovery In addition remove imagePullPolicy for operator and fallback to k8s defaults. Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
add-nic-feature-discovery
branch
from
08838f8
to
7ad3c61
Compare
ykulazhenkov
approved these changes
Sep 6, 2023
e0ne
approved these changes
Sep 6, 2023
| @@ -121,12 +121,18 @@ func newNicClusterPolicyStates(k8sAPIClient client.Client, scheme *runtime.Schem | |||
| nvIpamCniState, err := NewStateNVIPAMCNI( | |||
| k8sAPIClient, scheme, filepath.Join(manifestBaseDir, "state-nv-ipam-cni")) | |||
| if err != nil { | |||
| return nil, errors.Wrapf(err, "failed to create ib-kubernetes State") | |||
There was a problem hiding this comment.
np, while not related to this PR, it just bothered me :) plus im the one who originally added it.
|
@abdallahyas shouldnt we have CI reporting ? |
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Sep 25, 2023
This commit reverts a change from Mellanox#589 to fix failing CI. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.