-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nic feature discovery #589
Conversation
Still need to check this one on openshift cluster |
31064a6
to
7dd84bf
Compare
This state will deploy nic-feature-discovery daemon - Extend NicClusterPolicy CR with a new `nicFeatureDiscovery` field - Add nic-feature-discovery manifests (yamls) - Implement nic-feature-discovery state Signed-off-by: adrianc <adrianc@nvidia.com>
7dd84bf
to
08838f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@e0ne @ykulazhenkov PTAL, id like to try and merge this one by EOW. |
manifests/state-nic-feature-discovery/030-nic-feature-discovery-ds.yaml
Outdated
Show resolved
Hide resolved
Update Helm chart and templates tot support nic-feature-discovery In addition remove imagePullPolicy for operator and fallback to k8s defaults. Signed-off-by: adrianc <adrianc@nvidia.com>
08838f8
to
7ad3c61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -121,12 +121,18 @@ func newNicClusterPolicyStates(k8sAPIClient client.Client, scheme *runtime.Schem | |||
nvIpamCniState, err := NewStateNVIPAMCNI( | |||
k8sAPIClient, scheme, filepath.Join(manifestBaseDir, "state-nv-ipam-cni")) | |||
if err != nil { | |||
return nil, errors.Wrapf(err, "failed to create ib-kubernetes State") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np, while not related to this PR, it just bothered me :) plus im the one who originally added it.
@abdallahyas shouldnt we have CI reporting ? |
This commit reverts a change from Mellanox#589 to fix failing CI. Signed-off-by: Ivan Kolodiazhny <ikolodiazhny@nvidia.com>
No description provided.