-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPPool CRD NV-IPAM #594
Merged
Merged
IPPool CRD NV-IPAM #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
reviewed
Sep 6, 2023
9106e17
to
5e58e3e
Compare
deployment/network-operator/crds/nv-ipam.nvidia.com_ippools.yaml
Outdated
Show resolved
Hide resolved
5e58e3e
to
b909b84
Compare
ykulazhenkov
approved these changes
Sep 21, 2023
NV-IPAM updates: - Add support for IPPool CRD - Deprecate the configmap - Update templates with latest yamls configuration - Update documentation - Upgrade to v0.1.0 Signed-off-by: Fred Rolland <frolland@nvidia.com>
b909b84
to
cd81508
Compare
almaslennikov
approved these changes
Sep 22, 2023
e0ne
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It colud be merged once all merge conflicts are resolved and CI passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NV-IPAM updates: