Tighten up controller roles #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good once CI pass |
ykulazhenkov
reviewed
Sep 6, 2023
Remove wildcards from mellanox.com and cni.cncf.k8s.io API groups, use explicit objects instead. Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
force-pushed
the
removed-wildcard-permissions
branch
from
f2392a2
to
04498b6
Compare
ykulazhenkov
approved these changes
Sep 6, 2023
rollandf
approved these changes
Sep 6, 2023
|
@abdallahyas shouldnt our CI run on this one ? |
|
discussed offline with @abdallahyas he manually triggered CI on this PR. it passed. merging. |
almaslennikov
added a commit
to almaslennikov/network-operator
that referenced
this pull request
Sep 25, 2023
…oved-wildcard-permissions"" This reverts commit 5febfe5.
almaslennikov
added a commit
to almaslennikov/network-operator
that referenced
this pull request
Sep 25, 2023
…oved-wildcard-permissions"" This reverts commit 5febfe5. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
almaslennikov
added a commit
to almaslennikov/network-operator
that referenced
this pull request
Sep 25, 2023
…oved-wildcard-permissions"" This reverts commit 5febfe5. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
almaslennikov
added a commit
to almaslennikov/network-operator
that referenced
this pull request
Sep 25, 2023
…oved-wildcard-permissions"" This reverts commit 5febfe5. Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove wildcards from mellanox.com and cni.cncf.k8s.io API groups, use explicit objects instead.
Fixes #595