Fix behaviour for OFED wait label to handle additional scenarios #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0ne
approved these changes
Sep 22, 2023
| node := nodes.Items[i] | ||
| labelValue := "" | ||
| if _, hasOFED := nodesWithOFEDContainer[node.Name]; hasOFED { | ||
| labelValue = "true" |
There was a problem hiding this comment.
The name of the function is misleading in this case. Should it maybe be something like UpdateMofedWaitLabels?
There was a problem hiding this comment.
I renamed functions to reduce confusion
ykulazhenkov
force-pushed
the
fix-ofed-wait-label
branch
from
3e1982f
to
853f729
Compare
New scenarios: - set OFED wait to true when OFED remove and terminating - clean OFED wait label from the node if it doesn't have NVIDIA nic anymore Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
fix-ofed-wait-label
branch
from
853f729
to
7b5ff41
Compare
almaslennikov
approved these changes
Sep 25, 2023
e0ne
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New scenarios: