Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align RBAC rules #643

Merged
merged 1 commit into from
Oct 18, 2023
Merged

chore: Align RBAC rules #643

merged 1 commit into from
Oct 18, 2023

Conversation

rollandf
Copy link
Member

Align Helm RBAC Role template to the kubebuilder generated file in config/rbac/role.yaml.

Some of the permissions were relocated to allow easier diff.

@rollandf
Copy link
Member Author

Diff result:

$ diff deployment/network-operator/templates/role.yaml config/rbac/role.yaml 
1,15c1
< {{/*
<   Copyright 2020 NVIDIA
< 
<   Licensed under the Apache License, Version 2.0 (the "License");
<   you may not use this file except in compliance with the License.
<   You may obtain a copy of the License at
< 
<       http://www.apache.org/licenses/LICENSE-2.0
< 
<   Unless required by applicable law or agreed to in writing, software
<   distributed under the License is distributed on an "AS IS" BASIS,
<   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
<   See the License for the specific language governing permissions and
<   limitations under the License.
< */}}
---
> ---
20c6
<   name: {{ include "network-operator.fullname" . }}
---
>   name: manager-role

@rollandf
Copy link
Member Author

/retest-nic_operator_helm

1 similar comment
@rollandf
Copy link
Member Author

/retest-nic_operator_helm

@adrianchiris
Copy link
Collaborator

@rollandf please merge this one once CI is green. thx for aligning this !

Align Helm RBAC Role template to the kubebuilder
generated file in `config/rbac/role.yaml`

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@rollandf
Copy link
Member Author

/retest-nic_operator_kind

@rollandf rollandf merged commit c6220de into Mellanox:master Oct 18, 2023
15 checks passed
@rollandf rollandf deleted the align-yamls branch February 28, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants