chore: Align deployment yaml #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the operator deployment yamls between the Helm template and the kubebuilder generated yaml in `config/manager/manager.yaml`. Signed-off-by: Fred Rolland <frolland@nvidia.com>
adrianchiris
approved these changes
Oct 18, 2023
adrianchiris
approved these changes
Oct 18, 2023
adrianchiris
added a commit
that referenced
this pull request
Oct 31, 2023
Remove `control-plane: {{ .Release.Name }}-controller` selector from the
network-operator object in the helm chart
to fix helm upgrade behaviour.
With the current selector we will have the following error when trying
to upgrade from the latest GA version (23.7)
```
helm upgrade -n nvidia-network-operator network-operator ./network-operator -f myvalues.yaml
Error: UPGRADE FAILED: cannot patch "network-operator" with kind Deployment: Deployment.apps "network-operator" is i
nvalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"n
etwork-operator", "app.kubernetes.io/name":"network-operator", "control-plane":"network-operator-controller"}, Match
Expressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
```
The extra selector was added as a part of
#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the operator deployment yamls between
the Helm template and the kubebuilder generated
yaml in
config/manager/manager.yaml.