bug: delete NCP on Helm uninstall #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: could you rename the file to be suffixed with "-hook" (we should rename the one on insstall as well) |
e0ne
approved these changes
Oct 18, 2023
In PR Mellanox#593, the creation of the NicClusterPolicy CR via Helm has been marked to be done with Helm "post-install,post-upgrade". As a result, when Helm was uninstalled, the CR was not deleted. In order to keep previous behavior, a new post-delete hook is introduced to delete the CR if it was created by Helm. Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf
force-pushed
the
delete-cr-helm
branch
from
83395ae
to
7dc4fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #593, the creation of the NicClusterPolicy CR via Helm has been marked to be done with Helm "post-install,post-upgrade".
As a result, when Helm was uninstalled, the CR was not deleted.
In order to keep previous behavior, a new post-delete hook is introduced to delete the CR if it was created by Helm.