-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update all dependencies for the operator #685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is prerequisite for #600 ( |
/retest-nic_operator_helm |
e86680b
to
819cb0f
Compare
This was referenced Nov 22, 2023
Open
adrianchiris
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM,
one small comment RE comment in new const once addressed can be merged
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
The function is replaced with wait.PollUntilContextTimeout Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
819cb0f
to
2dc25e3
Compare
adrianchiris
approved these changes
Nov 27, 2023
rollandf
approved these changes
Nov 27, 2023
e0ne
added a commit
that referenced
this pull request
Dec 5, 2023
On Node startup, the OFED container takes some time to compile and load the driver. During that time, workloads might get scheduled on that Node. When OFED is loaded, all existing PODs that use NVIDIA NICs will lose their network interfaces. Some such PODs might silently fail or hang. To avoid such a situation, before the OFED container is loaded, the Node should get Cordoned and Drained to ensure all workloads are rescheduled. The Node should be un-cordoned when the driver is ready on it. The safe driver loading feature is implemented as a part of the upgrade flow, meaning safe driver loading is a special scenario of the upgrade procedure, where we upgrade from the inbox driver to the containerized OFED. depends on: #685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes:
controler-runtime
package changed the API, this PR also includes migration to the new APIk8s-operator-libs
package changed the API, this PR removes logic which is not required anymore and does migration to the new APIwait.Poll
function towait.PollUntilContextTimeout