Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status printer column for custom resources #96

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add status printer column for custom resources #96

merged 1 commit into from
Feb 11, 2021

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Feb 11, 2021 •
edited

This commit adds a status printer column which
reflects the global state of NicClusterPolicy and MacvlanNetwork CR instance.

Example:

$> kubectl get nicclusterpolicy
NAME                 STATUS
nic-cluster-policy   ready

@adrianchiris
Copy link
Collaborator Author

/cc @e0ne @Mmduh-483

e0ne
e0ne requested changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the same for MacvlanNetwork CR.

@adrianchiris
Add status printer column for Custom Resources
8c01f55 
This commit adds a `status` printer column which
reflects the global state of the following resources:
- NicClusterPolicy
- MacvlanNetwork

Example:
$> kubectl get nicclusterpolicy
NAME                 STATUS
nic-cluster-policy   ready

Signed-off-by: Adrian Chiris <adrianc@nvidia.com>
@adrianchiris adrianchiris changed the title Add status printer column Add status printer column for custom resources Feb 11, 2021
@adrianchiris
Copy link
Collaborator Author

Let's add the same for MacvlanNetwork CR.

@e0ne Done.

e0ne
e0ne approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!

@moshe010 moshe010 merged commit c4b85a7 into Mellanox:master Feb 11, 2021
@moshe010 moshe010 mentioned this pull request Mar 1, 2021
Closed
26 tasks
@adrianchiris adrianchiris deleted the add-status-printer-column branch May 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@moshe010 moshe010 moshe010 approved these changes

@Mmduh-483 Mmduh-483 Awaiting requested review from Mmduh-483

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianchiris @e0ne @moshe010