Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update nv-ipam to v0.2.0 #971

Merged
merged 1 commit into from
Jun 16, 2024
Merged

chore: update nv-ipam to v0.2.0 #971

merged 1 commit into from
Jun 16, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Jun 14, 2024 •
edited

This version contains support for static IPs and new CIDRPool API.

Changelog: https://github.com/Mellanox/nvidia-k8s-ipam/releases/tag/v0.2.0

@ykulazhenkov ykulazhenkov added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jun 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024 •
edited

Pull Request Test Coverage Report for Build 9512380326

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.6%) to 63.234%
Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_skel.go 2 84.23%
controllers/nicclusterpolicy_controller.go 3 79.08%
pkg/state/state_ipoib_network.go 4 75.24%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/ipoibnetwork_controller.go 7 77.38%
controllers/hostdevicenetwork_controller.go 15 75.0%
Totals Coverage Status
Change from base Build 9382713857: -0.6%
Covered Lines: 3218
Relevant Lines: 5089
💛 - Coveralls

@ykulazhenkov
Update nv-ipam to v0.2.0
cc32b31 
This version contains support for static IPs and new
CIDRPool API.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
ykulazhenkov commented Jun 14, 2024
View reviewed changes
Copy link
Collaborator Author

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nv-ipam v0.2.0 was released, the PR is ready for review

@ykulazhenkov ykulazhenkov removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jun 14, 2024
@ykulazhenkov ykulazhenkov marked this pull request as ready for review June 14, 2024 11:50
e0ne
e0ne approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It could be merged once CI pass

@coveralls
Copy link
Collaborator

coveralls commented Jun 14, 2024 •
edited

Pull Request Test Coverage Report for Build 9515600033

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 63.568%
Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
controllers/nicclusterpolicy_controller.go 9 75.31%
Totals Coverage Status
Change from base Build 9382713857: -0.2%
Covered Lines: 3235
Relevant Lines: 5089
💛 - Coveralls

@rollandf rollandf merged commit b14d5a2 into Mellanox:master Jun 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne approved these changes

@rollandf rollandf rollandf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ykulazhenkov @coveralls @e0ne @rollandf