Skip to content

Commit

Permalink
Fix label selector in examples for IPPool CR
Browse files Browse the repository at this point in the history
Replace `kubernetes.io/role` with
`node-role.kubernetes.io/worker` which is more common

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
  • Loading branch information
ykulazhenkov committed Oct 10, 2023
1 parent c7a6c38 commit 9ffbcc2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 24 deletions.
24 changes: 8 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,8 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists
```
2. ipam-controller calculates and assigns unique IP Blocks for each Node via IPPool Status:
Expand All @@ -100,10 +98,8 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists
perNodeBlockSize: 24
subnet: 192.168.0.0/16
status:
Expand Down Expand Up @@ -218,10 +214,8 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists
```
* `spec`: contains the IP pool configuration
Expand Down Expand Up @@ -383,10 +377,8 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists
EOF
```

Expand Down
6 changes: 2 additions & 4 deletions examples/ippool-1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,5 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists
6 changes: 2 additions & 4 deletions examples/ippool-2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,5 @@ spec:
nodeSelector:
nodeSelectorTerms:
- matchExpressions:
- key: kubernetes.io/role
operator: In
values:
- worker
- key: node-role.kubernetes.io/worker
operator: Exists

0 comments on commit 9ffbcc2

Please sign in to comment.