Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor changes to nv-ipam.yaml #10

Merged
merged 1 commit into from
May 5, 2023
Merged

minor changes to nv-ipam.yaml #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions deploy/nv-ipam.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ metadata:
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: kube-nv-ipam-node-ds
name: nv-ipam-node-ds
namespace: kube-system
labels:
tier: node
Expand All @@ -52,15 +52,14 @@ spec:
app: nv-ipam-node
name: nv-ipam-node
spec:
hostNetwork: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshe010 , it will now depend on CNI, do we need to introduce this dependency ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right if we want to support primary network it has to be hostNetwork: true and also the controller.

tolerations:
- operator: Exists
effect: NoSchedule
- operator: Exists
effect: NoExecute
serviceAccountName: nv-ipam-node
containers:
- name: kube-nv-ipam-node
- name: nv-ipam-node
image: ghcr.io/mellanox/nvidia-k8s-ipam:latest
imagePullPolicy: IfNotPresent
env:
Expand All @@ -69,6 +68,9 @@ spec:
fieldRef:
fieldPath: spec.nodeName
command: [ "/ipam-node" ]
args:
- --nv-ipam-log-file=/var/log/nv-ipam-cni.log
- --nv-ipam-log-level=info
resources:
requests:
cpu: "100m"
Expand Down