Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix know issues in IPAM controller implementation and add tests #11

Merged
merged 6 commits into from
May 8, 2023
Merged

Fix know issues in IPAM controller implementation and add tests #11

merged 6 commits into from
May 8, 2023

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented May 5, 2023 •
edited
Loading

  • fix ip library to correctly handle out of range IPs
  • validate IP address in allocator more strictly
  • fix check for gataway in config validator
  • add tests for IPAM controller

@ykulazhenkov
Fix ip package to handle invalid IPs correctly
f788715 
+ add test coverage for the package

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Enforce GW as required parameter in ConfigMap
398cf52 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov ykulazhenkov changed the title Fix know issues in IPAM controller implementation Fix know issues in IPAM controller implementation and add tests May 5, 2023
@ykulazhenkov
Add extra checks to Allocator to handle ip range overflow correctly
f1c1435 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Remove use of unneeded ip.Network function
0c77ba1 
It was used to mask IP of the net.IPNet objects,
but net.ParseCIDR, which is the only source
for net.IPNet objects, in our case,
already has this logic.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add tests for allocator and selector packages
8748c03 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add tests for IPAM controller
afa3254 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@adrianchiris adrianchiris merged commit e4a3f7b into Mellanox:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@moshe010 moshe010 Awaiting requested review from moshe010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykulazhenkov @adrianchiris