Add support for leader election #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@ykulazhenkov once PR#18 is merged, can you update "flags" section with updated flag set ? |
sure, will do |
By default, the leader election is enabled in the deployment yaml, but controller's replica count is set to 1. This is to prevent IPAM controller misbehaviour in case if user will decide to scale deployment. Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
updated |
|
This will require a followup PR in network operator as well. |
adrianchiris
approved these changes
May 9, 2023
moshe010
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the leader election is now enabled in the deployment yaml
but controller's replica count is set to 1.
This is required to prevent IPAM controller
misbehavior in case if user will decide to scale the deployment.