Add unit test #21
Merged
Add unit test #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
- use mockery to generate mocks: add makefile targets - refactor types and plugin, use interfaces for parsing config file and executing IPAM plugin as prep work for unit tests - generate mocks Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
|
coverage results are inaccurate, need to exclude mocks from cov results |
- generate list of packages to test - run test only on those packages - remove -coverpkg flag Signed-off-by: adrianc <adrianc@nvidia.com>
moshe010
reviewed
May 21, 2023
- newline in .mockery.yaml file - fix typo in Makefile - update test description pool test - use Ginkgo TempDir() in cmdtutils test - bump testify version to v1.8.3 Signed-off-by: adrianc <adrianc@nvidia.com>
ykulazhenkov
approved these changes
May 23, 2023
moshe010
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.