ipam-node: Remove stale pool entries from the store #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
force-pushed
the
remove-stale-pool
branch
from
5dde05b
to
ac528ac
Compare
adrianchiris
reviewed
Aug 7, 2023
| g.Expect(err).NotTo(HaveOccurred()) | ||
| defer store.Cancel() | ||
| g.Expect(store.GetReservationByID(testPool1, "id1", testIFName)).NotTo(BeNil()) | ||
| g.Expect(store.GetReservationByID(testPool1, "id2", testIFName)).NotTo(BeNil()) | ||
| g.Expect(store.GetReservationByID(testPool1, "id3", testIFName)).To(BeNil()) | ||
| g.Expect(store.GetReservationByID(testPool2, "id4", testIFName)).To(BeNil()) | ||
| g.Expect(store.GetReservationByID(testPool2, "id5", testIFName)).To(BeNil()) | ||
| // pool1 has entries, should be kept in the store |
There was a problem hiding this comment.
imo it would be clearer if we check what pools are left in store by listing and checking the pools.
there is a bit of a "hidden" knowledge here that if last reserved IP is nil then the only reason for this is that the pool does not exist.
There was a problem hiding this comment.
Thanks, make sense. fixed
remove the pool data from the store if the pool has no allocations and if information about the pool is unavailable in the Kubernetes API Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
remove-stale-pool
branch
from
ac528ac
to
9d0c23e
Compare
adrianchiris
approved these changes
Aug 8, 2023
adrianchiris
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the pool data from the store if the pool has no allocations and if information about the pool is unavailable in the Kubernetes API
closes #25