New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ipam-node #4

Merged

moshe010 merged 4 commits into Mellanox:main from moshe010:ipam-node

May 4, 2023

Contributor

moshe010 commented May 2, 2023

No description provided.

moshe010 changed the title ~~Impalement ipam-node~~ implement ipam-node

moshe010 force-pushed the ipam-node branch from ec9f8b4 to 39cf876 Compare

May 2, 2023 21:33


          update Dockerfile to build host-local IPAM

f4257f5

Signed-off-by: Moshe Levi <moshele@nvidia.com>

moshe010 force-pushed the ipam-node branch from 39cf876 to 51eceb6 Compare

May 2, 2023 21:35

moshe010 commented

View reviewed changes

Dockerfile Show resolved Hide resolved

cmd/ipam-node/main.go Show resolved Hide resolved

moshe010 force-pushed the ipam-node branch from 51eceb6 to 37d6e9d Compare

May 2, 2023 21:42

adrianchiris reviewed

View reviewed changes

Dockerfile Show resolved Hide resolved

moshe010 force-pushed the ipam-node branch from 37d6e9d to 81eec0e Compare

May 3, 2023 07:20

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Outdated Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Outdated Show resolved Hide resolved

moshe010 force-pushed the ipam-node branch from 81eec0e to 925521f Compare

May 3, 2023 07:38

adrianchiris reviewed

View reviewed changes

nv-ipam-node.yaml Outdated Show resolved Hide resolved

moshe010 force-pushed the ipam-node branch from 925521f to 042ae7e Compare

May 3, 2023 10:03

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Outdated Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go

+              		return nil, fmt.Errorf("cannot close nv-ipam-config temp file: %v", err)
+              	}
+              	newFileHash := hash.Sum(nil)

Collaborator

adrianchiris May 3, 2023

hash check mechanism is dead code currently.
also orig hash can be part of same method and not passed as arg from caller.

anyway, not relevant for now.

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Outdated Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

deploy/nv-ipam-node.yaml Outdated Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

deploy/nv-ipam-node.yaml Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

pkg/cmdutils/utils_test.go Outdated Show resolved Hide resolved

adrianchiris reviewed

View reviewed changes

cmd/ipam-node/main.go Outdated Show resolved Hide resolved

moshe010 added 3 commits

May 3, 2023 21:05


          ipam-node: implement ipam-node

5800f96

Signed-off-by: Moshe Levi <moshele@nvidia.com>


          ipam-node: add deployment

84b8df7

Signed-off-by: Moshe Levi <moshele@nvidia.com>


          update go mod

ceca9d6

Signed-off-by: Moshe Levi <moshele@nvidia.com>

moshe010 force-pushed the ipam-node branch from 042ae7e to ceca9d6 Compare

May 3, 2023 18:16

moshe010 merged commit 478b144 into Mellanox:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment