Add support for additional CNI arguments: ips, poolNames, poolType, allocateDefaultGateway #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
approved these changes
Jun 13, 2024
Supported options: STDIN runtimeConfig[ips] STDIN args[cni][ips] CNI_ARGS env variable, IP field Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
add `allocateDefaultGateway` flag to cni-args that activates the special behaviour. When CNI is called with this flag, the plugin will try to allocate IP address of the pool's default gateway as interface IP for the cotnainer.
ykulazhenkov
force-pushed
the
pr-cni-args
branch
from
5996fff
to
3917ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #44
Last 5 commits to review.
The PR contains the following changes:
poolNamesandpooTypein STDIN args[cni] (required to be able to inject values from multus annotaion)allocateDefaultGatewayflag. When CNI is called with this flag, the pluginwill try to allocate IP address of the pool's
default gateway as interface IP for the container
Documentation for the features will be submitted in a separate PR.