Add support for IP ranges exclusion for IPPool CRD #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasrem
approved these changes
Jun 12, 2024
| for _, alloc := range ipPool.Status.Allocations { | ||
| if alloc.NodeName == r.NodeName { | ||
| exclusions := make([]pool.ExclusionRange, 0, len(ipPool.Spec.Exclusions)) |
There was a problem hiding this comment.
Do we need to apply similar validations like we do in the CIDRPool controller? https://github.com/Mellanox/nvidia-k8s-ipam/pull/44/files#diff-81e2300ca5363063bc54cf99edda7f4cc4db78e8ac4c73eadc34205cab124eabR100
There was a problem hiding this comment.
I believe we don't need additional logic here. The node's allocator implementation will reject configurations where exclusions are outside of the node's subnet. In the case of IPPool, all nodes use the same subnet, so any exclusions that match the pool's subnet are valid for all nodes. However, with CIDRPool, each node has a unique subnet, so we need to filter the pool's exclusions and only pass valid exclusions to the node's allocator.
rollandf
approved these changes
Jun 13, 2024
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
ykulazhenkov
force-pushed
the
pr-ippool-excludes
branch
from
1575edd
to
9a60011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #44
Last commit to review.
This change is required to support "static IP" use-case with IPPool pools