Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning fix for format_ae_specific. #135

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

BrianLang
Copy link
Collaborator

  • Refactor to protect against warning in format_ae_specific.
  • Update news to reflect fix.

Could not reproduce warning we saw in the meeting, so I could not write a test for it. @wangben718, can you pull this down and see if it fixes your warning? The code in question should no longer be run in the case of users not requesting comparative statistics.

- Refactor to protect against warning in format_ae_specific.
- Update news to reflect fix.
@BrianLang BrianLang added the bug Something isn't working label Mar 23, 2023
@BrianLang BrianLang self-assigned this Mar 23, 2023
@BrianLang BrianLang requested a review from nanxstats March 23, 2023 18:07
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanxstats nanxstats merged commit e36692a into main Mar 23, 2023
@nanxstats nanxstats deleted the warningfix-format_ae_specific branch March 23, 2023 20:37
@BrianLang
Copy link
Collaborator Author

LGTM

TGIF 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants