Parepare cran release #186
Conversation
… checking in the result.
NEWS.md
Outdated
| - Updated `format_ae_specific` to avoid warning when no comparison variables are | ||
| requested. | ||
| ## New features | ||
| - `tlf_ae_summary()` and `tlf_ae_specific` now have a new argument `title` for a user-customized title. |
There was a problem hiding this comment.
tlf_ae_specific() should also have () for consistency
NEWS.md
Outdated
| - `tlf_ae_summary()` and `tlf_ae_specific` now have a new argument `title` for a user-customized title. | ||
| - Add new functions: `rate_compare_sum()`, `extend_ae_specific_subgroup()`, `prepare_ae_specific_subgroup()`, `format_ae_specific_subgroup()`, `tlf_ae_specific_subgroup()`, `extend_ae_summary_eaer()`, | ||
| `format_ae_exp_adj()` and `tlf_ae_exp_adj()`. | ||
| - Add `data/metalite_ae_adex.Rda`. |
There was a problem hiding this comment.
For .rda, the convention is to use all lower case .rda. If you data file name actually ends with .Rda, you need to rename it.
NEWS.md
Outdated
| - Add new functions: `rate_compare_sum()`, `extend_ae_specific_subgroup()`, `prepare_ae_specific_subgroup()`, `format_ae_specific_subgroup()`, `tlf_ae_specific_subgroup()`, `extend_ae_summary_eaer()`, | ||
| `format_ae_exp_adj()` and `tlf_ae_exp_adj()`. | ||
| - Add `data/metalite_ae_adex.Rda`. | ||
| - Add new vignettes: 'Subgroup Analysis for Specific AE' and 'Exposure Adjusted Event Rate'. |
There was a problem hiding this comment.
It doesn't help to say the titles here. vignette("vignette-file-name") will get linked and clickable.
NEWS.md
Outdated
| `format_ae_exp_adj()` and `tlf_ae_exp_adj()`. | ||
| - Add `data/metalite_ae_adex.Rda`. | ||
| - Add new vignettes: 'Subgroup Analysis for Specific AE' and 'Exposure Adjusted Event Rate'. | ||
| - Add test cases for new functions. |
There was a problem hiding this comment.
This belongs to "don't comment on the obvious" and thus should be removed.
NEWS.md
Outdated
| - Add `data/metalite_ae_adex.Rda`. | ||
| - Add new vignettes: 'Subgroup Analysis for Specific AE' and 'Exposure Adjusted Event Rate'. | ||
| - Add test cases for new functions. | ||
| - Add system organ class(SOC) information to `outdata` in `prepare_ae_specific()` |
There was a problem hiding this comment.
Should be styled as "System Organ Classes (SOC)" (title case and a whitespace)
| - Add test cases for new functions. | ||
| - Add system organ class(SOC) information to `outdata` in `prepare_ae_specific()` | ||
|
|
||
| ## Bug fixes |
There was a problem hiding this comment.
Need a blank line between headings and content.
NEWS.md
Outdated
| - Add system organ class(SOC) information to `outdata` in `prepare_ae_specific()` | ||
|
|
||
| ## Bug fixes | ||
| - Fix bug to avoid warning messages when no comparison variables are requested in `format_ae_specific()`. |
There was a problem hiding this comment.
Please link the PR at the end of the sentences following https://style.tidyverse.org/news.html.
NEWS.md
Outdated
| - Fix bug to correctly assign treatment labels when a treatment variable has `NA`. | ||
|
|
||
| ## Improvements | ||
| - Update Github Actions workflow. |
NEWS.md
Outdated
| - Remove `R/to_mock.R` and `R/to_sentence.R`, and `to_mock()` and `to_sentence()` are moved to `R/utility.R`. | ||
| - Remove library calls from tests. | ||
| - Add `R/outdata.R` to control `outdata` object. | ||
| - Add an installation section to `README.Rd`. |
NEWS.md
Outdated
| - Remove library calls from tests. | ||
| - Add `R/outdata.R` to control `outdata` object. | ||
| - Add an installation section to `README.Rd`. | ||
| - Improve style and formatting for vignettes and codes. |
|
Hi @fukuhiro2023 , could you please address these issues? |
|
Hi @wangben718 and @nanxstats , I have updated the |
No description provided.