update README.md and fix bug in fallback config lookup #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbrice
commented
Mar 13, 2024
Comment on lines
-62
to
+65
| "description": "If `true`, Alloglot will log more output." | ||
| "description": "If `true`, Alloglot will log more output.", | ||
| "default": null |
There was a problem hiding this comment.
The issue preventing the fallback from being used is that VS Code defaults boolean config options to false if the package.json doesn't specify a different default.
There was a problem hiding this comment.
My config-loading logic saw that user-level config "existed" (incorrectly) and so ignored the fallback.
azuzunaga
approved these changes
Mar 13, 2024
|
A PR to release these changes has been created, bumping the version from 3.0.1 to 3.0.2. |
| } | ||
|
|
||
| function timestamp(): string { | ||
| return new Date().toJSON().split('T')[1].replace(/\.\d*Z/, ' UTC') |
There was a problem hiding this comment.
Dates in vanilla JS, oh what fun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.