feat: add assignees option to the copy and backport commands #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #2334. I've no clue how to test this locally, though my changes in the test data were good enough 👑 |
3 tasks
sileht
reviewed
Apr 2, 2021
|
@v1v this pull request is now in conflict 😩 |
v1v
commented
Apr 6, 2021
docs/mergify_engine_gendoc.py
Outdated
Comment on lines
66
to
72
| f.write( | ||
| f"""<head> | ||
| <meta http-equiv="refresh" content="0; URL={url}"> | ||
| <link rel="canonical" href="{url}"> | ||
| </head> | ||
| """) | ||
| """ | ||
| ) |
There was a problem hiding this comment.
Unrelated change caused by the tox -e black command
v1v
force-pushed
the
feature/add-assignee-author-backport
branch
from
e646b00
to
80754d1
Compare
|
I've just changed the implementation to use the suggestion from #2336 (review) Though, I might need some help with the test data |
|
Fixtures for the functional need to setup a GitHub app and a couple of GitHub accounts and API keys. I will take care of it. |
sileht
changed the title
sileht
changed the title
sileht
reviewed
Apr 7, 2021
mergify_engine/duplicate_pull.py
Outdated
| @@ -349,4 +351,10 @@ async def duplicate( | |||
| json={"labels": effective_labels}, | |||
| ) | |||
|
|
|||
| if assignees is not None: | |||
There was a problem hiding this comment.
Need also checks len(assignes) > 0 to avoid useless HTTP request
docs/mergify_engine_gendoc.py
Outdated
Comment on lines
66
to
72
| f.write( | ||
| f"""<head> | ||
| <meta http-equiv="refresh" content="0; URL={url}"> | ||
| <link rel="canonical" href="{url}"> | ||
| </head> | ||
| """) | ||
| """ | ||
| ) |
sileht
force-pushed
the
feature/add-assignee-author-backport
branch
from
80754d1
to
90bf0c2
Compare
sileht
previously approved these changes
Apr 7, 2021
jd
previously requested changes
Apr 8, 2021
docs/source/actions/backport.rst
Outdated
Comment on lines
76
to
79
| - The users to assign to the pull request. | ||
|
|
||
| The list of users in ``assignees`` is based on :ref:`data type template`, you can use | ||
| e.g. ``{{author}}`` to assign the pull request to its author. |
There was a problem hiding this comment.
Suggested change
| - The users to assign to the pull request. | |
| The list of users in ``assignees`` is based on :ref:`data type template`, you can use | |
| e.g. ``{{author}}`` to assign the pull request to its author. | |
| - Users to assign the newly created pull request. As the type is :ref:`data type template`, you could use, e.g., ``{{author}}`` to assign the pull request to its original author. |
docs/source/actions/backport.rst
Outdated
| @@ -94,5 +100,6 @@ added and the pull request merged: | |||
| backport: | |||
| branches: | |||
| - stable | |||
| assignees: ["{{ author }}"] | |||
There was a problem hiding this comment.
Suggested change
| assignees: ["{{ author }}"] | |
| assignees: | |
| - "{{ author }}" |
I feel it's more readable :)
docs/source/actions/copy.rst
Outdated
Comment on lines
54
to
60
| * - ``assignees`` | ||
| - list of :ref:`data type template` | ||
| - | ||
| - The users to assign to the pull request. | ||
|
|
||
| The list of users in ``assignees`` is based on :ref:`data type template`, you can use | ||
| e.g. ``{{author}}`` to assign the pull request to its author. |
sileht
force-pushed
the
feature/add-assignee-author-backport
branch
from
90bf0c2
to
791fd5c
Compare
jd
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add assignees option to the copy and backport commands
Related issues
Fix #2287
Checklists
Development
hotfixlabelCode Review
Code review policies are handled and automated by Mergify.
remaining, pull request is retested against its base branch.