Fix for the issue #55. #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
reviewed
Sep 11, 2023
Comment on lines
+41
to
+45
| LOCK_EXPIRED_MESSAGE = ( | ||
| "The requested URL was not found on the server. " | ||
| "If you entered the URL manually please check your spelling and try again." | ||
| ) | ||
|
|
There was a problem hiding this comment.
I would probably feel safer if we just check for single line, maybe only "The requested URL was not found on the server"
@varmar05 for mergin-server, do we have some alpha-number error-code system in place?
There was a problem hiding this comment.
We do, but is implemented only partially (mostly for limits errors).
I guess this message comes with 404 and it is auto generated by connexion lib (validation above flask level).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added skipping unlocking project if project lock already expired on MM server.
fix #55